Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SubDofHandler/MixedGrid/PorousMedia example #448

Merged
merged 40 commits into from
Oct 7, 2023

Conversation

KnutAM
Copy link
Member

@KnutAM KnutAM commented Apr 14, 2022

Closes #355

Example for using both mixed grid and fields on subsets of the domain: Porous media with embedded impermeable particles. Link to example in docs preview

@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2022

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (3ffb34f) 92.75% compared to head (9dc7ff4) 92.77%.
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #448      +/-   ##
==========================================
+ Coverage   92.75%   92.77%   +0.02%     
==========================================
  Files          33       33              
  Lines        4952     4952              
==========================================
+ Hits         4593     4594       +1     
+ Misses        359      358       -1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KnutAM
Copy link
Member Author

KnutAM commented Apr 15, 2022

This is my naive attempt for an example that I would have liked to have when starting using the MixedDofHandler
Probably a few blunders, so I would be happy to get your opinions @kimauth, @lijas, and @fredrikekre, on if this is reasonable and what should be changed in the implementation. Then I can spend more time on beautifying and comment/theory clarifications!
(The loading case should change to highlight more that it is a coupled problem, but that shouldn't affect the code)

@KnutAM
Copy link
Member Author

KnutAM commented Dec 22, 2022

Edit: Better to be explicit, improved theory included already.

Note for later, if to be included in Ferrite.jl:
A simpler and shorter theory section, different boundary conditions, and using AD for the stiffness, can be found here. These changes can be made here as well.

docs/download_resources.jl Outdated Show resolved Hide resolved
docs/src/literate/porous_media.jl Outdated Show resolved Hide resolved
docs/src/literate/porous_media.jl Outdated Show resolved Hide resolved
docs/Manifest.toml Outdated Show resolved Hide resolved
src/Dofs/DofHandler.jl Outdated Show resolved Hide resolved
src/Dofs/DofHandler.jl Outdated Show resolved Hide resolved
@KnutAM KnutAM marked this pull request as ready for review July 2, 2023 13:53
@KnutAM KnutAM changed the title MixedDofHandler/PorousMedia example SubDofHandler/MixedGrid/PorousMedia example Jul 2, 2023
@KnutAM KnutAM requested a review from kimauth July 3, 2023 19:10
@termi-official
Copy link
Member

Is there something blocking this PR from merge?

@KnutAM
Copy link
Member Author

KnutAM commented Sep 22, 2023

Is there something blocking this PR from merge?

Missing review from my perspective...

@KnutAM
Copy link
Member Author

KnutAM commented Oct 2, 2023

Looks like the increased CI doc time is due to updated packages after updating the docs project (need to upgrade FerriteMeshParser to 0.1.7 to support the master branch).

@KnutAM KnutAM merged commit 2980391 into master Oct 7, 2023
6 checks passed
@KnutAM KnutAM deleted the kam/MixedDofHandlerExample branch October 7, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No examples with MixedDofHandler
3 participants