-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SparseMatrixCSR extension #864
base: master
Are you sure you want to change the base?
Conversation
49d273a
to
27d1980
Compare
27d1980
to
0c3efc8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #864 +/- ##
==========================================
+ Coverage 93.57% 93.70% +0.12%
==========================================
Files 39 40 +1
Lines 6074 6160 +86
==========================================
+ Hits 5684 5772 +88
+ Misses 390 388 -2 ☔ View full report in Codecov by Sentry. |
94ece96
to
8102774
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just took a look as I was curious, nice work on factoring out some parts - this will make it easier to extend!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
It could be nice to use the SparseMatrixCSR in one of the tutorials also (for testing and showing user that it is possible)
I suppose in all(?) cases the solver will dictate what matrix you need to, or can, use. Is there any solver that can handle SparseMatrixCSR but not SparseMatrixCSC? |
I decided to not use it in one of the tutorials for now, because I didn't wanted to clutter any of these. It should also be clear how to use it from the docstring of start_assemble ? Which test is missing in https://github.com/Ferrite-FEM/Ferrite.jl/pull/864/files#diff-7fa26eddc1fe6a8a5341e0fcdffb1d8c256e6a566819cfcf70b625ef80ab6abd ? (At least codecov says I have coverage). |
If you talk about matrix formats, then e.g. Ginkgo and Hypre just have CSR formats (and no CSC). |
Yea but then you wouldn't go through SparseMatrixCSR.jl but directly to a HYPRE matrix or Ginkgo matrix? |
Yes |
``` | ||
Ferrite.start_assemble! | ||
Ferrite.finish_assemble! | ||
Ferrite.assemble! | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the correct way to communicate this? Adding @docs
breaks the CI, because the doc string is already listed in references.
Towards #848 and #628 . This should show how we could assemble into custom sparse matrix formats.
TODO