-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respect colorrange and support nonlinear interpolations #119
Respect colorrange and support nonlinear interpolations #119
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR Knut! A few questions from my side
local_celldofs_field = reshape(@view(_celldofs[dof_range_]), (field_dim,length(cell.nodes))) | ||
local_celldofs_field = reshape(@view(_celldofs[dof_range_]), (field_dim, length(dof_range_)÷field_dim)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What exactly is fixed here? Both statements should be equivalent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, bad commit message - makes it work for superparameteric elements (and subparametric).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But I see now that this would fail below for subparametric and relies on that the linear dofs comes first for superparameteric (but I think they do...).
So probably a more complete solution would be desired...?
@@ -33,7 +33,7 @@ keyword arguments are: | |||
deformation_field=:default, | |||
process=postprocess, | |||
colormap=:cividis, | |||
colorrange=(0,1), | |||
colorrange=(0,0), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think what you want is something like
do I understand correctly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That might work too - I don't know the internal details enough to say, just made the minimum possible intrusive change I could come up with.
Currently, the problem was just that the provided colorrange was just overwritten here
So any solution respecting the provided input would be good.
While working I discovered a few issues, and am using this as my "fixes branch", hence the unrelated changes.
Towards #103 as based on that branch
Fixes
solutionplot
being respected (instead of being overwritten by the automatic range calculated from the data)