Updates from upstream #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i did some debugging and found that the lib/corsproxy.js seems to expect a well formed url instead of an object, probably just a change in the code that needed to be reflected in the readme target0 = url.parse(module.exports.options.target);
Small readme update
Remove log statement
Target port should always default to 80
Add basic auth headers when they passed in
Add auth header when specifying credentials via target url param
Update http-proxy version
BREAKING CHANGE Alles neu™ https://www.youtube.com/watch?v=DD0A2plMSVA
'Host' request header fixed
To forward query string parameters
see https://github.com/probot/stale for more information
I was using this but was unable to get it working from a different machine. I found the answer was to set CORSPROXY_HOST by looking at the source code. This isn't documented anywhere but I think it is a common enough usage to require explanation. This would have saved me some time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.