Change pcks12 usage to modern ciphers #561
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Using mkcert to create P12/PFX for use in nodejs >= 17 causes issues because of the deprecated RC2 usage. By upgrading https://pkg.go.dev/software.sslmate.com/src/go-pkcs12 to latest version, and using the
Modern
encoder (which currently points toModern2023
encoder settings), fixes the issue, for example issue #496Relevant links
These are the changes between current 0.2.0 and targeted 0.4.0: SSLMate/go-pkcs12@v0.2.0...v0.4.0
The most relevant commit is: SSLMate/go-pkcs12@b473b00 (18th July 2023)
Verifying
Before change:
After change: