Rename evented queue "waitFor" method "waitBehind" to maintain queue …

…metaphor 🐿 v2.10.0
Financial-Times · Feb 13, 2019 · 05dcd01 · 05dcd01
1 parent 3fccd98
commit 05dcd01
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/evented-queue.js b/src/evented-queue.js
@@ -18,7 +18,7 @@ class EventedQueue extends EventEmitter {
 		return this;
 	}
 
-	waitFor(items = []) {
+	waitBehind(items = []) {
 		return new Promise((resolve) => {
 			const callback = () => {
 				const itemsWaiting = items.some((item) => this.waiting.has(item));

diff --git a/src/run-parallel.js b/src/run-parallel.js
@@ -16,7 +16,7 @@ module.exports = (tasks = [], concurrency = 1, preserveOrder = false) => {
 
 			// wait for any dependencies still in the queue to finish
 			if (preserveOrder) {
-				await queue.waitFor(pkg.allDependencies);
+				await queue.waitBehind(pkg.allDependencies);
 			}
 
 			await apply();

diff --git a/test/src/evented-queue.spec.js b/test/src/evented-queue.spec.js
@@ -42,14 +42,14 @@ describe('src/evented-queue', () => {
 		});
 	});
 
-	describe('#waitFor', () => {
+	describe('#waitBehind', () => {
 		it('resolves when the queue no longer contains any of the given items', (done) => {
 			instance
 				.add('foo')
 				.add('bar')
 				.add('baz');
 
-			instance.waitFor(['foo', 'bar', 'baz']).then(() => {
+			instance.waitBehind(['foo', 'bar', 'baz']).then(() => {
 				expect(instance.waiting.size).toEqual(0);
 				done();
 			});