Merge pull request #30 from Financial-Times/matth/ignore-glob-matches…

…-without-manifest

Ignore glob matches which are not directories containing a package.json

src/cli-task.js

@@ -46,7 +46,7 @@ module.exports = (task) => {
 			logger.message(`Tasks complete, took ${timer.duration}s`);
 		} catch (error) {
 			const message = error instanceof Error ? error.message : error;
-			const exitCode = error.code || 1;
+			const exitCode = Number.isInteger(error.code) ? error.code : 1;
 
 			logger.error(`Task failed: "${message}"`);
 			process.exit(exitCode);

src/load-manifest.js

@@ -1,6 +1,16 @@
+const fs = require('fs');
 const path = require('path');
 
 module.exports = (packagePath) => {
-	const manifestPath = path.resolve(packagePath, 'package.json');
-	return require(manifestPath);
+	const stats = fs.statSync(packagePath);
+
+	if (stats.isDirectory()) {
+		const manifestPath = path.resolve(packagePath, 'package.json');
+
+		if (fs.existsSync(manifestPath)) {
+			return require(manifestPath);
+		} else {
+			throw Error(`Folder found without package.json file: ${packagePath}`)
+		}
+	}
 };

src/load-packages.js

@@ -4,9 +4,15 @@ const loadManifest = require('./load-manifest');
 
 module.exports = async (globs = []) => {
 	const locations = await getPackages(globs);
+	const packages = []
 
-	return locations.map((location) => {
+	locations.forEach((location) => {
 		const manifest = loadManifest(location);
-		return new Package(manifest, location);
+
+		if (manifest) {
+			packages.push(new Package(manifest, location));
+		}
 	});
+
+	return packages
 };