Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update x/foundation to use Finschia/cosmos-sdk #1198

Merged
merged 26 commits into from
Feb 2, 2024
Merged

feat: update x/foundation to use Finschia/cosmos-sdk #1198

merged 26 commits into from
Feb 2, 2024

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Dec 28, 2023 •
edited
Loading

Description

closes: #1197

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@0Tech 0Tech added the C:x/foundation x/foundation module label Dec 28, 2023
@0Tech 0Tech self-assigned this Dec 28, 2023
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 28, 2023
View reviewed changes
x/foundation/keeper/internal/vote.go Fixed Show fixed Hide fixed
x/foundation/keeper/internal/vote.go Fixed Show fixed Hide fixed
x/foundation/keeper/internal/treasury.go Fixed Show fixed Hide fixed
x/foundation/keeper/internal/proposal.go Fixed Show fixed Hide fixed
x/foundation/keeper/internal/proposal.go Fixed Show fixed Hide fixed
x/foundation/keeper/internal/member.go Fixed Show fixed Hide fixed
x/foundation/keeper/internal/censorship.go Fixed Show fixed Hide fixed
x/foundation/keeper/internal/censorship.go Fixed Show fixed Hide fixed
x/foundation/keeper/internal/censorship.go Fixed Show fixed Hide fixed
x/foundation/keeper/internal/censorship.go Fixed Show fixed Hide fixed
@jaeseung-bae jaeseung-bae deleted the branch bumpup50 December 28, 2023 09:17
@jaeseung-bae
Copy link
Contributor

I think I deleted bump50 by accident 2 weeks ago.
I didn't know the deletion. Sorry for the inconvenience.

@jaeseung-bae jaeseung-bae reopened this Jan 10, 2024
@0Tech 0Tech force-pushed the bumpup50-foundation branch 4 times, most recently from 7bc191a to 41838d4 Compare January 11, 2024 02:06
@0Tech
Copy link
Collaborator Author

0Tech commented Jan 11, 2024

Blocked by #1205.

ulbqb
ulbqb reviewed Jan 25, 2024
View reviewed changes
x/foundation/codec/cdc.go Outdated Show resolved Hide resolved
@ulbqb
Copy link
Member

ulbqb commented Jan 25, 2024

It's ok not to update simapp/app.go?

@ulbqb ulbqb closed this Jan 26, 2024
@ulbqb ulbqb reopened this Jan 26, 2024
@ulbqb
Copy link
Member

ulbqb commented Jan 29, 2024

How about removing simapp/app if we don't use app_v1?

ulbqb
ulbqb reviewed Jan 29, 2024
View reviewed changes
x/foundation/README.md Outdated Show resolved Hide resolved
x/foundation/README.md Show resolved Hide resolved
@0Tech
Copy link
Collaborator Author

0Tech commented Jan 29, 2024

How about removing simapp/app if we don't use app_v1?

I agree. Any opinions @jaeseung-bae @tkxkd0159 ?

@jaeseung-bae
Copy link
Contributor

How about removing simapp/app if we don't use app_v1?

I agree. Any opinions @jaeseung-bae @tkxkd0159 ?

After we remove it, no further effort on app_v1 is expected when we track upstream's code, isn't it??

@ulbqb ulbqb self-requested a review January 31, 2024 07:20
ulbqb
ulbqb approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@ulbqb ulbqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ulbqb ulbqb self-requested a review January 31, 2024 08:16
jaeseung-bae
jaeseung-bae approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@jaeseung-bae jaeseung-bae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0Tech 0Tech merged commit d9ebe72 into bumpup50 Feb 2, 2024
27 of 29 checks passed
@0Tech 0Tech deleted the bumpup50-foundation branch February 2, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeseung-bae jaeseung-bae jaeseung-bae approved these changes

@ulbqb ulbqb ulbqb approved these changes

Assignees

@0Tech 0Tech

Labels
C:x/foundation x/foundation module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0Tech @jaeseung-bae @ulbqb