Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syntax Changes in fdsreader #4

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Syntax Changes in fdsreader #4

wants to merge 3 commits into from

Conversation

Haukiy
Copy link

@Haukiy Haukiy commented Oct 17, 2023

  • updated syntax of fdsreader
  • Debugging: helped me find the error
  • Check: Added a check for the Slice height.
  • Extended Options: Introduced additional options (e.g. plot_time_aggl_abs_bool_vismap)
  • Demo Notebook (preview), further a good check
  • some small changes (e.g. readme)

Haukiy added 3 commits October 17, 2023 20:19
@Haukiy
Update Module to Syntax Changes in fdsreader
6242a17 
This commit updates the module to align with the latest syntax modifications in `fdsreader`.

- **Syntax Compatibility**: Adjusted the module to comply with the updated syntax of `fdsreader`, ensuring seamless integration.

Additional improvements and features added include:

- **Debugging Improvements**: Enhanced debugging capabilities for better error tracking and resolution.
- **Check**: Added a checks for the Slice height.
- **Extended Options**: Introduced additional options
- **Demo Notebook**: Included a demo notebook to showcase the functionality and new features of the updated module, providing a practical guide for users.
@Haukiy
Update README.md
d79e2bf
@Haukiy
Update README.md
0e9d450
chraibi
chraibi reviewed Apr 11, 2024
View reviewed changes
README.md
@@ -42,4 +42,4 @@ vis.compute_all()
vis.plot_time_aggl_abs_bool_vismap(size=[15,10],bbox_pad=1,fontsize=10,display_colorbar=True)
```
# Preview Notebook
[View the rendered example notebook](https://nbviewer.jupyter.org/github/Haukiy/fdsvismap/blob/main/demo_fds_vismap_nb.ipynb)
[View the example notebook](https://github.com/Haukiy/fdsvismap/blob/main/demo_fds_vismap_nb.ipynb)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use relative path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chraibi chraibi chraibi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Haukiy @chraibi