Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved support for type-mapped properties with custom conversion #44

Open
Firehed opened this issue Feb 15, 2024 · 0 comments
Open

Improved support for type-mapped properties with custom conversion #44

Firehed opened this issue Feb 15, 2024 · 0 comments

Comments

@Firehed
Copy link
Owner

Firehed commented Feb 15, 2024

In short, if you're using custom type mapping in Doctrine to store and retrieve objects (or even custom-named scalar values, I suppose), the strict equality check can lead to false-positives in tests that would pass in the actual database due to the storage conversion layer.

The most-complete solution would actually use Doctrine\DBAL\Types\* to convert to the storage format for ALL fields. Test bootstrapping would need to supplement the TypeRegistry (just as would normally occur) and then the comparison functions could encode with that type.

That probably also requires setting up some sort of AbstractPlatform... this gets complex fast.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant