Adopt RFC2119 terms for requirements language #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjg20
reviewed
Oct 17, 2024
source/transfer_list.rst
Outdated
| containing platform-specific data or internal structures specific to a single | ||
| firmware implementation is no reason not to allocate a standardized tag for it | ||
| firmware implementation, should allocate a standardized tag for it |
There was a problem hiding this comment.
That makes it significantly weaker. Is there a way to encourage this?
There was a problem hiding this comment.
This reword was a nitpick.
It's simply removing the double negative.
We can drop the change.
I've reworded the sentence a bit in the latest push (hopefully respecting the original language):
"
In particular, a creator of a TE that just contains platform-specific data or internal structures specific to a single firmware implementation, should allocate a standardized tag for it in this specification -- using the non-standardized range is strongly discouraged.
"
jmarinho
force-pushed
the
master
branch
2 times, most recently
from
817a9e5
to
74c0a3a
Compare
The IETF RFC2119 defines terms for requirements and guidance statements. This commit changes the spec to adopt those terms, where relevant, and requires future contributions to comply with RFC2119. Fix FirmwareHandoff#30 Change-Id: Ia4cc7f44bcd4508025f30d2410e83802c6ec4a11 Signed-off-by: Jose Marinho <jose.marinho@arm.com>
sjg20
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IETF RFC2119 defines terms for requirements and guidance statements. This commit changes the spec to adopt those terms, where relevant, and requires future contributions to comply with RFC2119.
Fix #30
Change-Id: Ia4cc7f44bcd4508025f30d2410e83802c6ec4a11