fix DecoderOnlyEmbedderICLSameDatasetTrainDataset category index error #1232
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was fine-tuning use the code in the documentation for
bge-en-icl
, an error occurred.error like:
Looking at the source code, I found that it was due to the
for
loop i variable in DecoderOnlyEmbedderICLSameDatasetTrainDataset._create_batch_data being overridden by the newfor
loop i variable inside.FlagEmbedding/FlagEmbedding/finetune/embedder/decoder_only/icl/dataset.py
Lines 68 to 69 in 9abcfc8
FlagEmbedding/FlagEmbedding/finetune/embedder/decoder_only/icl/dataset.py
Lines 116 to 117 in 9abcfc8
I modified the variable name of the inner for loop,
i -> j
, fix this bug.