Don't fetch user overrides in edit feature if user has no permissions

Flagsmith · Dec 17, 2024 · 569fa9f · 569fa9f
1 parent 8767c78
commit 569fa9f
Showing 1 changed file with 32 additions and 20 deletions.
diff --git a/frontend/web/components/modals/CreateFlag.js b/frontend/web/components/modals/CreateFlag.js
@@ -46,6 +46,7 @@ import { saveFeatureWithValidation } from 'components/saveFeatureWithValidation'
 import PlanBasedBanner from 'components/PlanBasedAccess'
 import FeatureHistory from 'components/FeatureHistory'
 import WarningMessage from 'components/WarningMessage'
+import { getPermission } from 'common/services/usePermission'
 
 const CreateFlag = class extends Component {
   static displayName = 'CreateFlag'
@@ -220,26 +221,37 @@ const CreateFlag = class extends Component {
   userOverridesPage = (page) => {
     if (Utils.getIsEdge()) {
       if (!Utils.getShouldHideIdentityOverridesTab(ProjectStore.model)) {
-        data
-          .get(
-            `${Project.api}environments/${this.props.environmentId}/edge-identity-overrides?feature=${this.props.projectFlag.id}&page=${page}`,
-          )
-          .then((userOverrides) => {
-            this.setState({
-              userOverrides: userOverrides.results.map((v) => ({
-                ...v.feature_state,
-                identity: {
-                  id: v.identity_uuid,
-                  identifier: v.identifier,
-                },
-              })),
-              userOverridesPaging: {
-                count: userOverrides.count,
-                currentPage: page,
-                next: userOverrides.next,
-              },
-            })
-          })
+        getPermission(getStore(), {
+          id: this.props.environmentId,
+          level: 'environment',
+          permissions: 'VIEW_IDENTITIES',
+        }).then((permissions) => {
+          if (permissions?.length) {
+            data
+              .get(
+                `${Project.api}environments/${this.props.environmentId}/edge-identity-overrides?feature=${this.props.projectFlag.id}&page=${page}`,
+              )
+              .then((userOverrides) => {
+                this.setState({
+                  userOverrides: userOverrides.results.map((v) => ({
+                    ...v.feature_state,
+                    identity: {
+                      id: v.identity_uuid,
+                      identifier: v.identifier,
+                    },
+                  })),
+                  userOverridesPaging: {
+                    count: userOverrides.count,
+                    currentPage: page,
+                    next: userOverrides.next,
+                  },
+                })
+              })
+              .catch((e) => {
+                console.log('Cannot retrieve user overrides')
+              })
+          }
+        })
       }
 
       return