From fedd296a5cc8eb07aa1db4a2cbb5eca8f124c098 Mon Sep 17 00:00:00 2001
From: Zach Aysan <zachaysan@gmail.com>
Date: Fri, 1 Nov 2024 04:54:00 -0400
Subject: [PATCH] fix: Set tag to get or create (#4790)

---
 .../feature_external_resources/models.py      |  2 +-
 ...t_unit_feature_external_resources_views.py | 45 +++++++++++++++++++
 2 files changed, 46 insertions(+), 1 deletion(-)

diff --git a/api/features/feature_external_resources/models.py b/api/features/feature_external_resources/models.py
index 3fcf60b86eb0..4e608694bf92 100644
--- a/api/features/feature_external_resources/models.py
+++ b/api/features/feature_external_resources/models.py
@@ -95,7 +95,7 @@ def execute_after_save_actions(self):
                 repository_name=repo,
             )
             if github_repo.tagging_enabled:
-                github_tag = Tag.objects.get(
+                github_tag, _ = Tag.objects.get_or_create(
                     label=tag_by_type_and_state[self.type][state],
                     project=self.feature.project,
                     is_system_tag=True,
diff --git a/api/tests/unit/features/test_unit_feature_external_resources_views.py b/api/tests/unit/features/test_unit_feature_external_resources_views.py
index d6ba8c501b14..370c25ec1bd9 100644
--- a/api/tests/unit/features/test_unit_feature_external_resources_views.py
+++ b/api/tests/unit/features/test_unit_feature_external_resources_views.py
@@ -23,6 +23,7 @@
 from integrations.github.constants import GITHUB_API_URL, GITHUB_API_VERSION
 from integrations.github.models import GithubConfiguration, GitHubRepository
 from projects.models import Project
+from projects.tags.models import Tag
 from segments.models import Segment
 from tests.types import WithEnvironmentPermissionsCallable
 from users.models import FFAdminUser
@@ -77,6 +78,7 @@ def test_create_feature_external_resource(
     post_request_mock: MagicMock,
     mock_github_client_generate_token: MagicMock,
 ) -> None:
+
     # Given
     repository_owner_name = (
         f"{github_repository.repository_owner}/{github_repository.repository_name}"
@@ -181,6 +183,49 @@ def test_create_feature_external_resource(
     )
 
 
+@responses.activate
+def test_create_feature_external_resource_missing_tags(
+    admin_client_new: APIClient,
+    feature_with_value: Feature,
+    segment_override_for_feature_with_value: FeatureState,
+    environment: Environment,
+    project: Project,
+    github_configuration: GithubConfiguration,
+    github_repository: GitHubRepository,
+    post_request_mock: MagicMock,
+    mock_github_client_generate_token: MagicMock,
+) -> None:
+
+    # Given
+    Tag.objects.all().delete()
+    repository_owner_name = (
+        f"{github_repository.repository_owner}/{github_repository.repository_name}"
+    )
+    feature_external_resource_data = {
+        "type": "GITHUB_ISSUE",
+        "url": f"https://github.com/{repository_owner_name}/issues/35",
+        "feature": feature_with_value.id,
+        "metadata": {"state": "open"},
+    }
+
+    url = reverse(
+        "api-v1:projects:feature-external-resources-list",
+        kwargs={"project_pk": project.id, "feature_pk": feature_with_value.id},
+    )
+
+    # When
+    response = admin_client_new.post(
+        url, data=feature_external_resource_data, format="json"
+    )
+
+    # Then
+    assert response.status_code == status.HTTP_201_CREATED
+    assert Tag.objects.count() == 1
+    tag = Tag.objects.first()
+    assert tag.project == project
+    assert tag.label == "Issue Open"
+
+
 def test_cannot_create_feature_external_resource_with_an_invalid_gh_url(
     admin_client_new: APIClient,
     feature: Feature,