Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "tag_based" field to role #4799

Closed
kyle-ssg opened this issue Nov 5, 2024 · 1 comment
Closed

Add "tag_based" field to role #4799

kyle-ssg opened this issue Nov 5, 2024 · 1 comment
Assignees
Labels
api Issue related to the REST API improvement Improvement to the existing platform

Comments

@kyle-ssg
Copy link
Member

kyle-ssg commented Nov 5, 2024

Is your feature request related to a problem? Please describe.

In order to make tag based permissions more intuitive, a whole role should be either tag based or not tag based.

Describe the solution you'd like.

Add a boolean tag_based (or equivalent if there's better wording suggestions). The frontend will use that to determine whether to restrict permission settings to supports_tag permissions.

Describe alternatives you've considered

Keep track of whether the project role permissions has tags and use that. This isn't very feasible since opting into tag based would have to be aware of any affected permissions.

Additional context

No response

@matthewelwell matthewelwell added improvement Improvement to the existing platform api Issue related to the REST API labels Nov 5, 2024
@kyle-ssg kyle-ssg linked a pull request Nov 5, 2024 that will close this issue
4 tasks
@kyle-ssg kyle-ssg removed a link to a pull request Nov 12, 2024
4 tasks
@kyle-ssg
Copy link
Member Author

No longer required since we're adding tags to permissions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API improvement Improvement to the existing platform
Projects
None yet
Development

No branches or pull requests

2 participants