Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(api): pkg-upgrade boto3@1.28.57 #2820

Closed

Conversation

hamishhossack
Copy link
Contributor

@hamishhossack hamishhossack commented Oct 2, 2023

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Upgrade boto3 package to the current latest 1.28.57, include documentation for using import or export within a local environment using localstack or similar.

How did you test this code?

I actually didn't find any good way to test this as a full solution, I guess pytest will cover some parts but there could be some potential side-effects where boto3 is used.

Any guidance here would be much appreciated.

Related Issue: #2811

@vercel
Copy link

vercel bot commented Oct 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2023 0:04am

@vercel
Copy link

vercel bot commented Oct 2, 2023

@hamishhossack is attempting to deploy a commit to the Flagsmith Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added api Issue related to the REST API docs Documentation updates labels Oct 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

Uffizzi Ephemeral Environment deployment-37348

☁️ https://app.uffizzi.com/github.com/Flagsmith/flagsmith/pull/2820

📄 View Application Logs etc.

What is Uffizzi? Learn more!

@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (929afeb) 95.53% compared to head (557d960) 95.53%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2820   +/-   ##
=======================================
  Coverage   95.53%   95.53%           
=======================================
  Files         994      994           
  Lines       28072    28072           
=======================================
  Hits        26818    26818           
  Misses       1254     1254           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewelwell
Copy link
Contributor

@hamishhossack I think the test pytest coverage should cover us here. I've checked the release notes for the 2 minor versions and I can't see anything that would cause us any problems. Could you resolve the conflicts here and we can approve / merge?

@matthewelwell
Copy link
Contributor

@hamishhossack I'm going to close this PR. Please re-open it once you're able to fix the conflicts. Thanks!

@hamishhossack
Copy link
Contributor Author

@matthewelwell Hey, sorry was on holiday!

It seems I don't have the power to re-open this specific PR, seems a bit drastic to create another one... can you re-open?

The rebased has been completed.

@matthewelwell
Copy link
Contributor

Erk, looks like Github be doing Github things so I don't think I can reopen it either 😞

image

I think you'll have to create another PR, I'm sorry.

@hamishhossack
Copy link
Contributor Author

re-created the PR here:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API docs Documentation updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants