-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(api): pkg-upgrade boto3@1.28.57 #2820
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@hamishhossack is attempting to deploy a commit to the Flagsmith Team on Vercel. A member of the Team first needs to authorize it. |
Uffizzi Ephemeral Environment
|
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2820 +/- ##
=======================================
Coverage 95.53% 95.53%
=======================================
Files 994 994
Lines 28072 28072
=======================================
Hits 26818 26818
Misses 1254 1254 ☔ View full report in Codecov by Sentry. |
@hamishhossack I think the test pytest coverage should cover us here. I've checked the release notes for the 2 minor versions and I can't see anything that would cause us any problems. Could you resolve the conflicts here and we can approve / merge? |
@hamishhossack I'm going to close this PR. Please re-open it once you're able to fix the conflicts. Thanks! |
@matthewelwell Hey, sorry was on holiday! It seems I don't have the power to re-open this specific PR, seems a bit drastic to create another one... can you re-open? The rebased has been completed. |
re-created the PR here: |
Thanks for submitting a PR! Please check the boxes below:
pre-commit
to check lintingChanges
Upgrade
boto3
package to the current latest 1.28.57, include documentation for using import or export within a local environment usinglocalstack
or similar.How did you test this code?
I actually didn't find any good way to test this as a full solution, I guess
pytest
will cover some parts but there could be some potential side-effects whereboto3
is used.Any guidance here would be much appreciated.
Related Issue: #2811