fix: Organisation can't have a new Github integration when had a prior one deleted #3874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: api/features/tasks.py
Did you find this useful? React with a 👍 or 👎 |
|
Uffizzi Preview |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3874 +/- ##
=======================================
Coverage 95.87% 95.87%
=======================================
Files 1129 1133 +4
Lines 35787 35858 +71
=======================================
+ Hits 34309 34378 +69
- Misses 1478 1480 +2 ☔ View full report in Codecov by Sentry. |
zachaysan
reviewed
May 2, 2024
Comment on lines
55
to
63
| @pytest.mark.parametrize( | ||
| "client", | ||
| [lazy_fixture("admin_master_api_key_client"), lazy_fixture("admin_client")], | ||
| ) | ||
| def test_cannot_create_github_configuration_due_to_unique_constraint( | ||
| client: APIClient, | ||
| organisation: Organisation, | ||
| github_configuration: GithubConfiguration, | ||
| ) -> None: |
There was a problem hiding this comment.
Suggested change
| @pytest.mark.parametrize( | |
| "client", | |
| [lazy_fixture("admin_master_api_key_client"), lazy_fixture("admin_client")], | |
| ) | |
| def test_cannot_create_github_configuration_due_to_unique_constraint( | |
| client: APIClient, | |
| organisation: Organisation, | |
| github_configuration: GithubConfiguration, | |
| ) -> None: | |
| def test_cannot_create_github_configuration_due_to_unique_constraint( | |
| admin_client_new: APIClient, | |
| organisation: Organisation, | |
| github_configuration: GithubConfiguration, | |
| ) -> None: |
Comment on lines
83
to
91
| @pytest.mark.parametrize( | ||
| "client", | ||
| [lazy_fixture("admin_master_api_key_client"), lazy_fixture("admin_client")], | ||
| ) | ||
| def test_cannot_create_github_configuration_when_the_organization_already_has_an_integration( | ||
| client: APIClient, | ||
| organisation: Organisation, | ||
| github_configuration: GithubConfiguration, | ||
| ) -> None: |
There was a problem hiding this comment.
Suggested change
| @pytest.mark.parametrize( | |
| "client", | |
| [lazy_fixture("admin_master_api_key_client"), lazy_fixture("admin_client")], | |
| ) | |
| def test_cannot_create_github_configuration_when_the_organization_already_has_an_integration( | |
| client: APIClient, | |
| organisation: Organisation, | |
| github_configuration: GithubConfiguration, | |
| ) -> None: | |
| def test_cannot_create_github_configuration_when_the_organization_already_has_an_integration( | |
| admin_client_new: APIClient, | |
| organisation: Organisation, | |
| github_configuration: GithubConfiguration, | |
| ) -> None: |
api/integrations/github/views.py
Outdated
Comment on lines
71
to
74
| try: | ||
| return super().create(request, *args, **kwargs) | ||
| except IntegrityError: | ||
| raise DuplicateGitHubIntegration |
There was a problem hiding this comment.
Is there a way of looking at the IntegrityError message in order to raise DuplicateGitHubIntegration only when the preconditions have been met?
novakzaballa
changed the title
novakzaballa
deleted the
fix/solve-problem-with-github-integration-when-it-was-deleted
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
How did you test this code?