Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Workaround for Pydantic misbehaving with FreezeGun #3876

Merged
merged 1 commit into from
May 2, 2024

Conversation

zachaysan
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Introduce a pytest hook that runs before all the tests and runs an import which disables a typing error that Pydantic has with FreezeGun.

How did you test this code?

Watched a sample test fail. Added the workaround. Watched the sample test pass.

@zachaysan zachaysan requested a review from matthewelwell May 2, 2024 14:33
Copy link

vercel bot commented May 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview May 2, 2024 2:33pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview May 2, 2024 2:33pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview May 2, 2024 2:33pm

@github-actions github-actions bot added the api Issue related to the REST API label May 2, 2024
Copy link
Contributor

github-actions bot commented May 2, 2024

Uffizzi Preview deployment-51159 was deleted.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.87%. Comparing base (41981d4) to head (24431cb).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3876   +/-   ##
=======================================
  Coverage   95.86%   95.87%           
=======================================
  Files        1131     1131           
  Lines       35834    35839    +5     
=======================================
+ Hits        34354    34359    +5     
  Misses       1480     1480           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zachaysan zachaysan added this pull request to the merge queue May 2, 2024
Merged via the queue into main with commit 5a0693b May 2, 2024
22 checks passed
@zachaysan zachaysan deleted the chore/pydantic-freezegun branch May 2, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants