Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Linkedin partner tracking #3879

Merged
merged 3 commits into from
May 8, 2024
Merged

chore: Linkedin partner tracking #3879

merged 3 commits into from
May 8, 2024

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented May 3, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Adds linkedin partner tracking when LINKEDIN_PARTNER_TRACKING=true

How did you test this code?

  • Ran the frontend with LINKEDIN_PARTNER_TRACKING=true, validated conversion events were sent.
  • Validated no requests are sent to Linkedin when the variable is disabled

Copy link

vercel bot commented May 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2024 10:29am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2024 10:29am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2024 10:29am

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard api Issue related to the REST API labels May 3, 2024
Copy link
Contributor

github-actions bot commented May 3, 2024

Uffizzi Preview deployment-51197 was deleted.

Copy link
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one minor specific comment based on the implementation but I'm also keen to make sure that we've verified this doesn't cause any unnecessary outbound requests when the option is disabled, e.g. for self hosted installations. I can't see any reference to it in the test section of the PR description.

api/app/views.py Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.87%. Comparing base (54c2603) to head (7dab079).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3879   +/-   ##
=======================================
  Coverage   95.86%   95.87%           
=======================================
  Files        1130     1131    +1     
  Lines       35795    35854   +59     
=======================================
+ Hits        34315    34374   +59     
  Misses       1480     1480           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kyle-ssg
Copy link
Member Author

kyle-ssg commented May 3, 2024

Added one minor specific comment based on the implementation but I'm also keen to make sure that we've verified this doesn't cause any unnecessary outbound requests when the option is disabled, e.g. for self hosted installations. I can't see any reference to it in the test section of the PR description.

Yeah, it wouldn't. The script only gets added to the page if the env var is set https://github.com/Flagsmith/flagsmith/pull/3879/files#diff-d2af3ec690c6d6d6c4691ed1d668ec2cf39c84b774cef27c7346e5efd555d321R106

@kyle-ssg kyle-ssg linked an issue May 7, 2024 that may be closed by this pull request
Copy link
Contributor

@novakzaballa novakzaballa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code LGTM but I left a comment regarding self-hosted case.

api/app/views.py Show resolved Hide resolved
@kyle-ssg kyle-ssg added this pull request to the merge queue May 8, 2024
Merged via the queue into main with commit efd3714 May 8, 2024
22 checks passed
@kyle-ssg kyle-ssg deleted the chore/linkedin-track branch May 8, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up tracking linkedin tracking for saas
4 participants