Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Ignore TYPE_CHECKING in coverage by default #3891

Merged

Conversation

khvn26
Copy link
Member

@khvn26 khvn26 commented May 7, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

After merging this PR, we won't have to manually mark imports under if TYPE_CHECKING: and abstract methods with # pragma: no cover.

How did you test this code?

This is a CI change.

@khvn26 khvn26 requested review from a team and zachaysan and removed request for a team May 7, 2024 16:42
Copy link

vercel bot commented May 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2024 4:45pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2024 4:45pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2024 4:45pm

Copy link
Contributor

github-actions bot commented May 7, 2024

Uffizzi Preview deployment-51385 was deleted.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.92%. Comparing base (b66747f) to head (7f10209).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3891      +/-   ##
==========================================
+ Coverage   95.87%   95.92%   +0.05%     
==========================================
  Files        1134     1134              
  Lines       36009    35958      -51     
==========================================
- Hits        34522    34493      -29     
+ Misses       1487     1465      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewelwell matthewelwell added this pull request to the merge queue May 8, 2024
Merged via the queue into main with commit b975831 May 8, 2024
22 checks passed
@matthewelwell matthewelwell deleted the chore/ignore-type-checking-in-coverage-by-default branch May 8, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants