Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Check if a valid GitHub installation exists #3893

Closed

Conversation

novakzaballa
Copy link
Contributor

@novakzaballa novakzaballa commented May 7, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Add a status field into GithubConfiguration model.
  • Changes when creating a comment on GitHub notifying the change of a feature flag.
  • Check if installation_id is valid.
  • Move call_github_app_webhook_for_feature_state task out from api/features/tasks.py to trigger_feature_state_change_webhooks_signal.

How did you test this code?

  • Unit Tests added

Copy link

vercel bot commented May 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 1:29pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 1:29pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 1:29pm

@github-actions github-actions bot added the api Issue related to the REST API label May 7, 2024
Copy link
Contributor

github-actions bot commented May 7, 2024

Uffizzi Preview deployment-51404 was deleted.

@codecov-commenter
Copy link

codecov-commenter commented May 7, 2024

Codecov Report

Attention: Patch coverage is 70.47619% with 31 lines in your changes are missing coverage. Please review.

Project coverage is 95.86%. Comparing base (53e728a) to head (8dd0cc9).
Report is 14 commits behind head on main.

Files Patch % Lines
api/integrations/github/client.py 33.33% 12 Missing ⚠️
api/features/signals.py 53.33% 7 Missing ⚠️
api/features/tasks.py 25.00% 6 Missing ⚠️
api/integrations/github/views.py 83.33% 4 Missing ⚠️
api/integrations/github/models.py 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3893      +/-   ##
==========================================
- Coverage   95.87%   95.86%   -0.01%     
==========================================
  Files        1133     1135       +2     
  Lines       35873    36046     +173     
==========================================
+ Hits        34393    34556     +163     
- Misses       1480     1490      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants