Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disable segment override diffs for non versioned environments #3914

Merged

Conversation

kyle-ssg
Copy link
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Disables segment override comparison in change requests when versioning is disabled.

How did you test this code?

Viewed existing wrong change request in production demo environment

Copy link

vercel bot commented May 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2024 10:10am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2024 10:10am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2024 10:10am

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label May 10, 2024
@kyle-ssg kyle-ssg requested a review from matthewelwell May 10, 2024 10:05
Copy link
Contributor

github-actions bot commented May 10, 2024

Uffizzi Preview deployment-51553 was deleted.

@kyle-ssg kyle-ssg added this pull request to the merge queue May 10, 2024
Merged via the queue into main with commit e5b4313 May 10, 2024
21 checks passed
@kyle-ssg kyle-ssg deleted the fix/disable-change-request-segment-diff-for-non-versioned branch May 10, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants