feat(analytics): Add command to migrate analytics data to pg #3981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Uffizzi Preview |
gagantrivedi
force-pushed
the
feat/migrate-influx-data-to-pg
branch
from
785f0b8 to
e5a68ad
Compare
gagantrivedi
force-pushed
the
feat/migrate-influx-data-to-pg
branch
from
e5a68ad to
fe83bfd
Compare
gagantrivedi
force-pushed
the
feat/migrate-influx-data-to-pg
branch
2 times, most recently
from
42280b3 to
b9b4d59
Compare
Add command to migrate feature analytics data from influxdb to postgres
gagantrivedi
force-pushed
the
feat/migrate-influx-data-to-pg
branch
from
b9b4d59 to
e4ec116
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3981 +/- ##
========================================
Coverage 96.41% 96.42%
========================================
Files 1145 1148 +3
Lines 37303 37430 +127
========================================
+ Hits 35967 36092 +125
- Misses 1336 1338 +2 ☔ View full report in Codecov by Sentry. |
zachaysan
approved these changes
May 28, 2024
api/app_analytics/migrate_to_pg.py
Outdated
| from app_analytics.models import FeatureEvaluationBucket | ||
|
|
||
|
|
||
| def migrate_feature_evaluations(migrate_till: int = 30): |
There was a problem hiding this comment.
Suggested change
| def migrate_feature_evaluations(migrate_till: int = 30): | |
| def migrate_feature_evaluations(migrate_till: int = 30) -> None: |
| reason="Skip test if analytics database is not configured", | ||
| ) | ||
| @pytest.mark.django_db(databases=["analytics", "default"]) | ||
| def test_migrate_feature_evaluations(mocker: MockerFixture): |
There was a problem hiding this comment.
Suggested change
| def test_migrate_feature_evaluations(mocker: MockerFixture): | |
| def test_migrate_feature_evaluations(mocker: MockerFixture) -> None: |
| def test_migrate_feature_evaluations(mocker: MockerFixture): | ||
| # Given | ||
| feature_name = "test_feature_one" | ||
| environment_id = "1" |
There was a problem hiding this comment.
It feels odd to me that environment_id is set to a string here.
There was a problem hiding this comment.
Yeah, but unfortunately this is the data type our functions expects (historical reasons)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
Add command to migrate feature analytics data from InfluxDB to Postgres
How did you test this code?
Tested manually with an external InfluxDB and added a unit test.