fix: Setting LOG_FORMAT: json does not write stack traces to logs
#4040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khvn26
requested review from
a team and
gagantrivedi
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
khvn26
changed the title
LOG_FORMAT: json does not write stack traces to logs
|
Uffizzi Preview |
zachaysan
approved these changes
May 29, 2024
api/tests/unit/util/test_logging.py
Outdated
Comment on lines
35
to
36
| "Traceback (most recent call last):\n" | ||
| ' File "/Users/kgustyr/dev/flagsmith/flagsmith/api/tests/unit/util/test_logging.py",' |
There was a problem hiding this comment.
Looks like you're going to need to fix the $HOME and work part of the filepath.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4040 +/- ##
=======================================
Coverage 96.41% 96.42%
=======================================
Files 1146 1146
Lines 37373 37386 +13
=======================================
+ Hits 36035 36048 +13
Misses 1338 1338 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
Fixes #4039.
How did you test this code?
Expanded the existing unit test.