fix: Environment creating state

[kyle-ssg]

Thanks for submitting a PR! Please check the boxes below:

• I have run pre-commit to check linting
• I have added information to docs/ if required so people know about the feature!
• I have filled in the "Changes" section below?
• I have filled in the "How did you test this code" section below?
• I have used a Conventional Commit title for this Pull Request

Changes

Disables create env button when creating

How did you test this code?

• Created an environment

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 5, 2024 10:10am
flagsmith-frontend-preview	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 5, 2024 10:10am
flagsmith-frontend-staging	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 5, 2024 10:10am

[github-actions]

Uffizzi Preview deployment-52474 was deleted.

[rolodato]

The bug I originally reported is fixed, but we're introducing the same behaviour as in #4026. If the request fails or is blocked, the Create button will never be re-enabled and no error is displayed.

Approving anyway because it's better to need to refresh the page than to delete duplicated environments :)

[kyle-ssg]

@rolodato I've fixed the above in the PR

[rolodato]

Not sure if I'm looking at the correct deployment, but I can reproduce the same behaviour by blocking the request to clone an environment in https://flagsmith-frontend-staging-4x2teb60z-flagsmith.vercel.app/ :

block.env.create.mov

[kyle-ssg]

Ah yep I forgot that #4058 is yet to be merged, added the relevant fixes here too.

[rolodato]

I see the button correctly being disabled while the environment is being created, but I don't see an error visibly reported if blocking the request or trying to clone an environment while offline:

create.env.no.error.mov

[kyle-ssg]

Ah yep, spotted the issue here.

This is now fixed, going to merge as am convinced this works now.