fix: Metadata UI issues

[novakzaballa]

Thanks for submitting a PR! Please check the boxes below:

• I have run pre-commit to check linting
• I have added information to docs/ if required so people know about the feature!
• I have filled in the "Changes" section below?
• I have filled in the "How did you test this code" section below?
• I have used a Conventional Commit title for this Pull Request

Changes

Related with: #3986

1. This Tooltip doesn't make any sense to me. I don't think it's necessary as we have the description and link to the docs below.

Now

2. I'm not sure what these null values are. Maybe this is old data.

I couldn't reproduce this issue; perhaps it was because the data at that time was correct.

3. Requeried -> Required

4. Be more descriptive in locations where metadata should be shown, guiding users to where they can configure the metadata.

How did you test this code?

• Create metadata for some entity

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
flagsmith-frontend-preview	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 17, 2024 10:11pm
flagsmith-frontend-staging	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 17, 2024 10:11pm

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
docs	⬜️ Ignored (Inspect)	Visit Preview		Jun 17, 2024 10:11pm

[github-actions]

Uffizzi Preview deployment-52502 was deleted.

[matthewelwell]

This looks a lot better but I still think the 'Metadata' section when creating / editing an entity can be improved. Specifically for Segments and Features. I think we should:

1. Add an option to show / hide the metadata
2. When there are no metadata fields for an entity type, we should perhaps display something beneath the header (perhaps instead of the tooltip).

With the above 2 suggestions, I think we could end with something like the following:

Generally, I am also concerned regarding segments that, if the metadata gets too large, then we are overtaking the 'Rules' tab with the metadata which feels wrong. Should we add a new tab to the Segment modal for the metadata instead?

Also, we need to make sure that we're paying attention to these things on creation of entities. For example, I just noticed that it's not currently possible to create an environment which has required metadata. We should check if the clone behaviour works correctly (and decide whether it should be included in the clone behaviour).

[matthewelwell]

@novakzaballa this is better, but there are still some issues. I've fixed a couple of typos and added a link to the project settings in a commit here.

I'm also still not happy with the approach for showing metadata for segments. I think it should be it's own tab. Can we add that please?

[novakzaballa]

@novakzaballa this is better, but there are still some issues. I've fixed a couple of typos and added a link to the project settings in a commit here.

I'm also still not happy with the approach for showing metadata for segments. I think it should be it's own tab. Can we add that please?

@matthewelwell I added the Tab

[matthewelwell]

Thanks for adding the tab, I think that's much better. I've added a few more pieces of feedback below:

This shouldn't be collapsed by default, or even collapsible at all really now that it's in its own tab

When creating a new segment, this icon indicating that something has changed looks like it's something in the metadata tab that needs attention. Can this icon be aware of the tab in which something has changed?

I like that this icon shows when a specific metadata field has been edited, but it can be removed when just switching between the 2 tabs. If this is difficult to resolve, we can just remove it entirely.

[novakzaballa]

Thanks for adding the tab, I think that's much better. I've added a few more pieces of feedback below:

This shouldn't be collapsed by default, or even collapsible at all really now that it's in its own tab

When creating a new segment, this icon indicating that something has changed looks like it's something in the metadata tab that needs attention. Can this icon be aware of the tab in which something has changed? I like that this icon shows when a specific metadata field has been edited, but it can be removed when just switching between the 2 tabs. If this is difficult to resolve, we can just remove it entirely.

I have already made the changes.

[matthewelwell]

Looks like there's still an issue regarding the icon displaying whether something has changed. When I edit the metadata, the icon shows that the rules have changed.

https://www.loom.com/share/07667735cdf041d4b1cc4c6ac08c1e1e?sid=f76cb099-0c77-4e15-8f47-1d30525f97cd

Also, it's odd to me that, when creating a segment, the metadata tab has an icon indicating that it's been changed, but the Basic Configuration tab doesn't. My preference would be that, on create, we don't show the icon at all. On edit, we show the icon only on the tabs that has/have been edited.

[novakzaballa]

Also, it's odd to me that, when creating a segment, the metadata tab has an icon indicating that it's been changed, but the Basic Configuration tab doesn't. My preference would be that, on create, we don't show the icon at all. On edit, we show the icon only on the tabs that has/have been edited.

Ok, I made the last changes.