fix: facilitate FE display of environment version from audit log #4077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4077 +/- ##
=======================================
Coverage 96.43% 96.44%
=======================================
Files 1149 1149
Lines 37535 37565 +30
=======================================
+ Hits 36198 36228 +30
Misses 1337 1337 ☔ View full report in Codecov by Sentry. |
…eve an environment feature version without the path args
matthewelwell
force-pushed
the
fix/add-fields-to-audit-log-serializer
branch
from
8e876a6 to
eb8ccb5
Compare
matthewelwell
force-pushed
the
fix/add-fields-to-audit-log-serializer
branch
from
0ecbcc4 to
444a68d
Compare
matthewelwell
commented
Jun 3, 2024
| @@ -46,7 +47,6 @@ | |||
| ) | |||
| class EnvironmentFeatureVersionViewSet( | |||
| GenericViewSet, | |||
| RetrieveModelMixin, | |||
There was a problem hiding this comment.
As mentioned in the description, this is technically a breaking API change but, since the versioning feature has not been released to anyone yet, I don't see this as an issue.
gagantrivedi
approved these changes
Jun 3, 2024
matthewelwell
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
This PR addresses 2 issues found by the FE in the integration as per this issue:
related_object_uuidto the response when retrieving audit log records from the APIEnvironmentFeatureVersionwithout the need for the environment and feature args in the URL path. This is due to the need from the FE to retrieve the version directly from the audit log which does not have the id of the feature directly available.Note that, based on this, I have removed the
RetrieveModelMixinfrom theEnvironmentFeatureVersionViewSetsince it is not needed. Technically this is a breaking API change but, since the versioning feature has not been released anywhere yet, I don't see that this is an issue.How did you test this code?
Added a bunch of new tests.