fix(versioning): prevent FeatureSegment from writing audit log on delete when v2 versioning enabled #4088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewelwell
requested review from
a team and
khvn26
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
matthewelwell
requested review from
a team and
zachaysan
and removed request for
khvn26 and
a team
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4088 +/- ##
=======================================
Coverage 96.44% 96.44%
=======================================
Files 1149 1149
Lines 37575 37589 +14
=======================================
+ Hits 36238 36252 +14
Misses 1337 1337 ☔ View full report in Codecov by Sentry. |
zachaysan
approved these changes
Jun 3, 2024
Comment on lines
+392
to
+395
| def get_skip_create_audit_log(self) -> bool: | ||
| # Don't create audit logs when deleting feature segments using versioning | ||
| # v2 as we rely on the version history instead. | ||
| return self.environment_feature_version_id is not None |
There was a problem hiding this comment.
nit: I would do the following
Suggested change
| def get_skip_create_audit_log(self) -> bool: | |
| # Don't create audit logs when deleting feature segments using versioning | |
| # v2 as we rely on the version history instead. | |
| return self.environment_feature_version_id is not None | |
| @property | |
| def is_skip_create_audit_log(self) -> bool: | |
| # Don't create audit logs when deleting feature segments using versioning | |
| # v2 as we rely on the version history instead. | |
| return self.environment_feature_version_id is not None |
matthewelwell
deleted the
fix(versioning)/prevent-feature-segment-delete-audit-log
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
Prevents the application from writing an AuditLog record when a feature segment is deleted if v2 versioning is enabled.
How did you test this code?
Added a new unit test.