ci(test-private-package): update trigger to use pull_request #4101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Ignored Deployments
|
Use pull request trigger with api label instead of merge_group to run private package tests
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4101 +/- ##
==========================================
+ Coverage 96.44% 96.49% +0.05%
==========================================
Files 1149 1174 +25
Lines 37596 38122 +526
==========================================
+ Hits 36259 36787 +528
+ Misses 1337 1335 -2 ☔ View full report in Codecov by Sentry. |
zachaysan
approved these changes
Jun 6, 2024
github-actions
bot
added
ci-cd
github-actions
bot
added
ci-cd
gagantrivedi
added
api
|
Uffizzi Preview |
gagantrivedi
added
api
github-actions
bot
added
ci-cd
github-actions
bot
added
ci-cd
gagantrivedi
added
api
Yeah, it was a nasty one! Fixed now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
Use pull request trigger with api label instead of merge_group to run private package tests
Fix test to use mock instead of updating setting so that other tests can avoid reloading the module
How did you test this code?
Workflow ran successfully here: https://github.com/Flagsmith/flagsmith/actions/runs/9435463004/job/25988919376?pr=4101