Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: save empty segment overrides request #4112

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Jun 5, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • On an environment with versioning enabled, creating a change request with empty segment overrides was not sending the version id. This was due to it using the version id of the feature states that were used to create the version, a version now returns its id at the root level.

How did you test this code?

  • Created a change request with no segments
  • Created a change request with just feature states
  • Saved a feature without a change request
  • Saved segment overrides without a change request

Copy link

vercel bot commented Jun 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2024 5:49pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2024 5:49pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2024 5:49pm

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard fix labels Jun 5, 2024
Copy link
Contributor

github-actions bot commented Jun 5, 2024

Uffizzi Preview deployment-52679 was deleted.

@matthewelwell matthewelwell added this pull request to the merge queue Jun 5, 2024
Merged via the queue into main with commit 6dbcb4a Jun 5, 2024
18 checks passed
@matthewelwell matthewelwell deleted the fix/empty-segment-overrides-version branch June 5, 2024 20:09
Copy link

sentry-io bot commented Jun 6, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: w is undefined fn(common/stores/feature-list-store) View Issue
  • ‼️ TypeError: w is undefined fn(common/stores/feature-list-store) View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants