-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add UserSignUpMeta model #4113
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Ignored Deployments
|
Uffizzi Ephemeral Environment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall approach looks great. I'd have marked this PR as approved but according to the PR description there are testing and other TODOs that need to land first.
('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')), | ||
('created_at', models.DateTimeField(auto_now_add=True)), | ||
('updated_at', models.DateTimeField(auto_now=True)), | ||
('json_meta', models.TextField()), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's too bad we can't use a json field here due to other databases
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4113 +/- ##
==========================================
- Coverage 96.44% 96.44% -0.01%
==========================================
Files 1149 1150 +1
Lines 37596 37669 +73
==========================================
+ Hits 36259 36329 +70
- Misses 1337 1340 +3 ☔ View full report in Codecov by Sentry. |
Closing as this was a failed attempt at getting around Hubspots uselessness. We will need to develop a custom form in hubspot and use that to create the contacts instead of using their native APIs. |
Thanks for submitting a PR! Please check the boxes below:
pre-commit
to check lintingdocs/
if required so people know about the feature!Changes
As part of a request from the marketing team we need to capture, and send to Hubspot, information about how the user arrived at Flagsmith when a new user signs up. For example, when clicking on a google ad, the website receives a query string that the FE then adds to a cookie.
This PR adds logic to retrieve the data from that cookie and store it in a new model which is then (TODO) used to send the correct attribution data to Hubspot.
How did you test this code?
TODO