fix(versioning): send live from when creating versions for change requests #4116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
front-end
|
Uffizzi Preview |
matthewelwell
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4116 +/- ##
=======================================
Coverage 96.44% 96.44%
=======================================
Files 1149 1149
Lines 37596 37596
=======================================
Hits 36259 36259
Misses 1337 1337 ☔ View full report in Codecov by Sentry. |
novakzaballa
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
This PR updates the FE code to send the
live_fromattribute when creating a new version for a change request. It also updates the property on theChangeRequestfrom_live_fromtolive_fromso that we can use it in the flagsmith-workflows module.How did you test this code?
Ran the FE locally and confirmed that the
live_fromattribute is correctly sent when creating a version for a change request. I also regression tested it to confirm that it's not sent when creating a new version that should not be scheduled.