Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(versioning): use version live from #4118

Merged
merged 4 commits into from
Jun 5, 2024

Conversation

matthewelwell
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Use the live_from value from the first environment feature version instead of the feature state if it exists.

How did you test this code?

Need to first merge the code in #4117, then we can test this using the preview URL.

Copy link

vercel bot commented Jun 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2024 11:36pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2024 11:36pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2024 11:36pm

@github-actions github-actions bot added fix front-end Issue related to the React Front End Dashboard labels Jun 5, 2024
@matthewelwell matthewelwell marked this pull request as ready for review June 5, 2024 22:38
@github-actions github-actions bot added fix and removed fix labels Jun 5, 2024
Copy link
Contributor

github-actions bot commented Jun 5, 2024

Uffizzi Preview deployment-52698 was deleted.

Copy link
Contributor

@novakzaballa novakzaballa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but left a comment, please verify the comment.

Merged via the queue into main with commit 0345aff Jun 5, 2024
18 checks passed
@matthewelwell matthewelwell deleted the fix(versioning)/use-version-live-from branch June 5, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants