Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Identity overrides tab #4134

Merged
merged 1 commit into from
Jun 10, 2024
Merged

fix: Identity overrides tab #4134

merged 1 commit into from
Jun 10, 2024

Conversation

novakzaballa
Copy link
Contributor

@novakzaballa novakzaballa commented Jun 7, 2024 •
edited
Loading

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Use environmentFlag prop instead environmentFlag state because this was undefined for creating the identity override

How did you test this code?

  • Try to select an identity in the Identity overrides tab.

@vercel Vercel
Copy link

vercel bot commented Jun 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Jun 7, 2024 9:00pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Jun 7, 2024 9:00pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Jun 7, 2024 9:00pm

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard fix labels Jun 7, 2024
@novakzaballa novakzaballa linked an issue Jun 7, 2024 that may be closed by this pull request
The identity override tab within the feature modal is not working #4133
Closed
4 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 7, 2024 •
edited
Loading

Uffizzi Preview deployment-52799 was deleted.

davidkrijgsman
davidkrijgsman reviewed Jun 8, 2024
View reviewed changes
Copy link

@davidkrijgsman davidkrijgsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@kyle-ssg kyle-ssg added this pull request to the merge queue Jun 10, 2024
Merged via the queue into main with commit 1a51fd3 Jun 10, 2024
18 checks passed
@kyle-ssg kyle-ssg deleted the fix/identity-overrides-tab branch June 10, 2024 07:09
@dabeeeenster dabeeeenster mentioned this pull request Jun 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidkrijgsman davidkrijgsman davidkrijgsman left review comments

@kyle-ssg kyle-ssg kyle-ssg approved these changes

Assignees
No one assigned
Labels
fix front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The identity override tab within the feature modal is not working
3 participants
@novakzaballa @kyle-ssg @davidkrijgsman