Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Grafana integration #4144

Merged
merged 14 commits into from
Jun 24, 2024
Merged

feat: Grafana integration #4144

merged 14 commits into from
Jun 24, 2024

Conversation

dabeeeenster
Copy link
Contributor

@dabeeeenster dabeeeenster commented Jun 11, 2024 •
edited
Loading

Adds a Grafana integration, similar to New Relic and Datadog.

Relevant API is https://grafana.com/docs/grafana/latest/developers/http_api/annotations/#create-annotation

@dabeeeenster dabeeeenster requested a review from a team June 11, 2024 11:13
@vercel Vercel
Copy link

vercel bot commented Jun 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jun 24, 2024 9:34am
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Jun 24, 2024 9:34am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Jun 24, 2024 9:34am

@dabeeeenster dabeeeenster requested a review from agregoryfs June 11, 2024 11:13
@github-actions github-actions bot added api Issue related to the REST API feature New feature or request labels Jun 11, 2024
@dabeeeenster dabeeeenster marked this pull request as draft June 11, 2024 11:13
@dabeeeenster dabeeeenster changed the title feat: grafana integration feat: Grafana integration Jun 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 11, 2024 •
edited
Loading

Uffizzi Preview deployment-52881 was deleted.

@github-actions github-actions bot added docs Documentation updates feature New feature or request and removed feature New feature or request docs Documentation updates labels Jun 11, 2024
@dabeeeenster dabeeeenster requested review from matthewelwell and removed request for agregoryfs June 11, 2024 11:20
@github-actions github-actions bot added feature New feature or request docs Documentation updates and removed feature New feature or request docs Documentation updates labels Jun 11, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.54%. Comparing base (5bafb4c) to head (8582a66).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4144      +/-   ##
==========================================
+ Coverage   96.51%   96.54%   +0.03%     
==========================================
  Files        1177     1190      +13     
  Lines       38293    38547     +254     
==========================================
+ Hits        36959    37216     +257     
+ Misses       1334     1331       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added docs Documentation updates feature New feature or request and removed feature New feature or request docs Documentation updates labels Jun 11, 2024
@khvn26 khvn26 force-pushed the feat/grafana-integration branch from 0b734a1 to e5272ee Compare June 23, 2024 15:17
@github-actions github-actions bot added feature New feature or request and removed docs Documentation updates labels Jun 23, 2024
@khvn26 khvn26 marked this pull request as ready for review June 23, 2024 15:27
@khvn26 khvn26 requested review from a team as code owners June 23, 2024 15:27
@khvn26 khvn26 requested review from novakzaballa and removed request for a team June 23, 2024 15:27
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Jun 23, 2024
@github-actions github-actions bot added docs Documentation updates feature New feature or request and removed feature New feature or request docs Documentation updates labels Jun 23, 2024
@khvn26
Copy link
Member

khvn26 commented Jun 24, 2024 •
edited
Loading

  • Moved the integration to project level.
  • Added tags to annotations, including boolean flag state and feature tags from Flagsmith.
  • Added a get_audited_instance_from_audit_log_record service function to extract audited objects from an audit log in a generic way.
  • Improved code coverage.
  • Improved documentation.

matthewelwell
matthewelwell reviewed Jun 24, 2024
View reviewed changes
Copy link
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good on the whole. Added a couple of minor comments.

api/integrations/grafana/mappers.py Show resolved Hide resolved
api/util/util.py Outdated Show resolved Hide resolved
@github-actions github-actions bot added feature New feature or request docs Documentation updates and removed feature New feature or request docs Documentation updates labels Jun 24, 2024
@matthewelwell matthewelwell added this pull request to the merge queue Jun 24, 2024
Merged via the queue into main with commit 5c25c41 Jun 24, 2024
32 checks passed
@matthewelwell matthewelwell deleted the feat/grafana-integration branch June 24, 2024 13:37
@dabeeeenster dabeeeenster mentioned this pull request Jun 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewelwell matthewelwell matthewelwell approved these changes

@khvn26 khvn26 Awaiting requested review from khvn26

@novakzaballa novakzaballa Awaiting requested review from novakzaballa novakzaballa is a code owner automatically assigned from Flagsmith/flagsmith-front-end

Assignees
No one assigned
Labels
api Issue related to the REST API feature New feature or request front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dabeeeenster @khvn26 @matthewelwell