Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update workflow to give correct permissions #4157

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

matthewelwell
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Updates the workflow definition for adding labels based on conventional commit title to ensure that external contributors (e.g. dependabot) can correctly add labels to their PRs.

Resolves issue seen here

image

Reference articles:

  1. https://stackoverflow.com/questions/70435286/resource-not-accessible-by-integration-on-github-post-repos-owner-repo-ac
  2. https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs

How did you test this code?

This PR will test to confirm that there is no regression in the workflow file, but I'll need to merge and then rebase the dependabot PR to confirm if it resolves the issue it's trying to fix.

@matthewelwell matthewelwell requested review from a team and gagantrivedi and removed request for a team June 13, 2024 10:18
Copy link

vercel bot commented Jun 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Jun 13, 2024 10:18am
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Jun 13, 2024 10:18am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Jun 13, 2024 10:18am

@github-actions github-actions bot added the ci-cd Build, test and deployment related label Jun 13, 2024
Copy link
Contributor

github-actions bot commented Jun 13, 2024

Uffizzi Preview deployment-53007 was deleted.

@matthewelwell matthewelwell added this pull request to the merge queue Jun 13, 2024
Merged via the queue into main with commit a966de9 Jun 13, 2024
21 checks passed
@matthewelwell matthewelwell deleted the ci/fix-conventional-commit-workflow branch June 13, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-cd Build, test and deployment related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants