fix: Include free plans for api use notifications #4204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Ignored Deployments
|
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4204 +/- ##
=======================================
Coverage 96.51% 96.51%
=======================================
Files 1177 1177
Lines 38230 38290 +60
=======================================
+ Hits 36896 36956 +60
Misses 1334 1334 ☔ View full report in Codecov by Sentry. |
matthewelwell
approved these changes
Jun 20, 2024
| assert email.body == ( | ||
| "Hi there,\n\nThe API usage for Test Org has breached " | ||
| "100% within the current subscription period. Please " | ||
| "upgrade your organisations account to ensure " |
There was a problem hiding this comment.
Suggested change
| "upgrade your organisations account to ensure " | |
| "upgrade your organisation's account to ensure " |
There was a problem hiding this comment.
Ok no problem. I've fixed the other invocations as well in the other tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
Includes free plans in the API use notifications with a rolling 30 day window as their effective start date. It also included some extra code to ensure that they're not including in automatic payment adjustments since free plans don't have credit cards.
How did you test this code?
Two existing tests and a new one just for free plans.