fix: oauth user case sensitivity #4207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hat are split between github and google get a consistent experience
matthewelwell
requested review from
a team and
novakzaballa
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Ignored Deployments
|
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4207 +/- ##
==========================================
+ Coverage 96.51% 96.52% +0.01%
==========================================
Files 1177 1177
Lines 38230 38354 +124
==========================================
+ Hits 36896 37023 +127
+ Misses 1334 1331 -3 ☔ View full report in Codecov by Sentry. |
matthewelwell
requested review from
zachaysan
and removed request for
novakzaballa
zachaysan
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Resolves #4185.
The main goal of this PR is to ensure that users who authenticate with an OAuth provider after authenticating with email/password, another OAuth provider, or even SAML (although this use case is slim) get a consistent experience. Currently if the email differs by case, a new user will be created and the user will likely be confused as to why they can't see their projects, etc.
As a side effect, we had to handle a few edge cases where a user might already have duplicate accounts and make sure that the user gets the same experience they do today (authenticating with method A gets them into user A, authenticating with user B gets them user B).
We should, separate to this, get in touch with the users for whom this is an issue (~20) and try to merge their accounts.
How did you test this code?
Added 3 new tests to cover all scenarios.