Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add confirmations when removing features, segments and environments #4210

Merged
merged 3 commits into from
Jun 24, 2024
Merged

feat: Add confirmations when removing features, segments and environments #4210

merged 3 commits into from
Jun 24, 2024

Conversation

kyle-ssg
Copy link
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Adds a toast message when removing features, segments and environments

How did you test this code?

Removed features, segments and environments

@vercel Vercel
Copy link

vercel bot commented Jun 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2024 2:00pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2024 2:00pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jun 21, 2024 2:00pm

@github-actions github-actions bot added chore front-end Issue related to the React Front End Dashboard and removed chore labels Jun 21, 2024
@kyle-ssg kyle-ssg linked an issue Jun 21, 2024 that may be closed by this pull request
Provide more feedback when deleting features, segments and environments #3994
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 21, 2024 •
edited
Loading

Uffizzi Preview deployment-53335 was deleted.

@kyle-ssg kyle-ssg requested a review from rolodato June 21, 2024 12:38
@github-actions github-actions bot added the chore label Jun 21, 2024
@github-actions github-actions bot added chore and removed chore labels Jun 21, 2024
rolodato
rolodato approved these changes Jun 21, 2024
View reviewed changes
Copy link
Member

@rolodato rolodato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this change is a new feature, not a chore - it's genuinely useful to anyone deleting things. Other than that it works great :)

@matthewelwell matthewelwell changed the title chore: Add confirmations when removing features, segments and environments feat: Add confirmations when removing features, segments and environments Jun 24, 2024
@matthewelwell matthewelwell added this pull request to the merge queue Jun 24, 2024
Merged via the queue into main with commit cdc3410 Jun 24, 2024
21 checks passed
@matthewelwell matthewelwell deleted the chore/remove-confirmations branch June 24, 2024 15:27
@dabeeeenster dabeeeenster mentioned this pull request Jun 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolodato rolodato rolodato approved these changes

Assignees

@rolodato rolodato

Labels
chore front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide more feedback when deleting features, segments and environments
3 participants
@kyle-ssg @rolodato @matthewelwell