-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add more granular permissions based on tags #4250
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Uffizzi Preview |
<FormGroup className='mb-5 setting'> | ||
<InputGroup | ||
title={'Tags'} | ||
tooltip={'Select the project where you want to manage your tags'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks wrong, we need to provide good context here about what adding tags to a role means. Can we link out to some documentation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added documentation
organisationId={organisationId!} | ||
onChange={(p) => { | ||
setProject(p) | ||
getTags( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason why this is called? seems wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at this more closely, it does look like this is unnecessary. AddEditTags uses useGetTagsQuery.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, removed.
I think I understand, so this lets us create a role with permissions but just targets a tagged set of flags? If so I have further questions that are not indicated by this work, apologies if I'm assuming something wrong: Presumably only certain permissions are affected by the tags that are selected and the rest aren't?
I'm going to assume that this affects Delete feature, Create feature, Update feature state, Create change request and Approve change request?
|
This tab hides when a tag is saved in the role
Projects that do not have the same tags as the role should not be displayed.
All features that aren't relevant have been hidden. |
Thanks for submitting a PR! Please check the boxes below:
pre-commit
to check lintingdocs/
if required so people know about the feature!Changes
Based on the issue: #1535
How did you test this code?
To properly test the functionality, this issue must be resolved first.