Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(segments): add migration to set version on existing segments #4315

Merged

Conversation

matthewelwell
Copy link
Contributor

Changes

Fixes issue introduced by #4138 where existing segments did not have a default version.

How did you test this code?

Ran the same query on the production database manually and verified that the issue was resolved.

@matthewelwell matthewelwell requested a review from a team as a code owner July 9, 2024 10:45
@matthewelwell matthewelwell requested review from novakzaballa and removed request for a team July 9, 2024 10:45
Copy link

vercel bot commented Jul 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Jul 9, 2024 10:45am
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Jul 9, 2024 10:45am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Jul 9, 2024 10:45am

@github-actions github-actions bot added api Issue related to the REST API fix labels Jul 9, 2024
Copy link
Contributor

github-actions bot commented Jul 9, 2024

flagsmith-frontend image build and security scan finished ✨

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-frontend:pr-4315 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Jul 9, 2024

flagsmith-e2e image build finished ✨

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-4315 Finished ✅ Skipped

Copy link
Contributor

github-actions bot commented Jul 9, 2024

flagsmith-private-cloud image build and security scan finished ✨

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4315 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Jul 9, 2024

flagsmith image build and security scan finished ✨

Image Build Status Security report
ghcr.io/flagsmith/flagsmith:pr-4315 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Jul 9, 2024

flagsmith-api image build and security scan finished ✨

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api:pr-4315 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Jul 9, 2024

Uffizzi Preview deployment-53987 was deleted.

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.60%. Comparing base (007351c) to head (34ab39a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4315   +/-   ##
=======================================
  Coverage   96.60%   96.60%           
=======================================
  Files        1195     1196    +1     
  Lines       39104    39113    +9     
=======================================
+ Hits        37778    37787    +9     
  Misses       1326     1326           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewelwell matthewelwell added this pull request to the merge queue Jul 9, 2024
Merged via the queue into main with commit 288a47e Jul 9, 2024
32 checks passed
@matthewelwell matthewelwell deleted the fix/add-migration-to-set-default-segment-version branch July 9, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants