-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support blank identifiers, assume transient #4449
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
Docker builds report
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4449 +/- ##
==========================================
+ Coverage 96.85% 96.89% +0.04%
==========================================
Files 1170 1174 +4
Lines 38812 39161 +349
==========================================
+ Hits 37592 37947 +355
+ Misses 1220 1214 -6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added some comments to some specific areas in the code, but I also had one more general comment regarding the PR description.
Identifiers are returned to keep consistency with Edge API.
I'm not quite clear on this? I think perhaps it's just related to including the identifier in the API response, as we do in the Edge API.
api/tests/integration/environments/identities/test_integration_identities.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Matthew Elwell <matthew.elwell@flagsmith.com>
…l identities, improve typing
ada1826
to
2f3af09
Compare
Note: changed transient identifier generation to a hash of traits as advised by Gagan's review of the Edge API PR. |
Thanks for submitting a PR! Please check the boxes below:
docs/
if required so people know about the feature!Changes
Closes #4448.
This PR adds the following for
POST
/api/v1/identities
:"transient": true
, all provided traits are automatically considered transient.How did you test this code?
Updated integration and unit tests with new cases.