Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set grace period to a singular event #4455

Merged
merged 4 commits into from
Aug 6, 2024

Conversation

zachaysan
Copy link
Contributor

Changes

This sets up a new model to track whether or not a organisation has hit their first grace period and if so further restricts their use of the application.

How did you test this code?

A new unit test.

@zachaysan zachaysan requested a review from a team as a code owner August 6, 2024 18:14
@zachaysan zachaysan requested review from matthewelwell and removed request for a team August 6, 2024 18:14
Copy link

vercel bot commented Aug 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Aug 6, 2024 6:34pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Aug 6, 2024 6:34pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Aug 6, 2024 6:34pm

@github-actions github-actions bot added the api Issue related to the REST API label Aug 6, 2024
@zachaysan zachaysan requested review from khvn26 and removed request for matthewelwell August 6, 2024 18:14
@github-actions github-actions bot added the fix label Aug 6, 2024
Copy link
Contributor

github-actions bot commented Aug 6, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-4455 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-4455 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4455 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4455 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4455 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4455 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Aug 6, 2024

Uffizzi Preview deployment-55020 was deleted.

@github-actions github-actions bot added fix and removed fix labels Aug 6, 2024
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.85%. Comparing base (5cbdd7f) to head (5bf7970).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4455   +/-   ##
=======================================
  Coverage   96.85%   96.85%           
=======================================
  Files        1170     1171    +1     
  Lines       38812    38846   +34     
=======================================
+ Hits        37592    37626   +34     
  Misses       1220     1220           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zachaysan zachaysan added this pull request to the merge queue Aug 6, 2024
Merged via the queue into main with commit 3225c47 Aug 6, 2024
35 checks passed
@zachaysan zachaysan deleted the fix/set_grace_period_to_a_singular_event branch August 6, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants