fix: Identity overrides are not deleted when deleting Edge identities #4460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
|
Uffizzi Preview |
Docker builds report
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4460 +/- ##
==========================================
+ Coverage 96.85% 96.88% +0.03%
==========================================
Files 1171 1172 +1
Lines 38846 39060 +214
==========================================
+ Hits 37626 37845 +219
+ Misses 1220 1215 -5 ☔ View full report in Codecov by Sentry. |
matthewelwell
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!Changes
Closes #4457.
Closes #3370.
This adds an Edge V2 table update trigger on Edge identity deletion. As a side effect, we'll have identity override deletion audit logs whenever an Edge identity is deleted, which is better UX than we have now, I believe.
How did you test this code?
Improved upon an existing integration test by using table mocks instead of a wrapper mock used previously.