Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Deprecate group-level permissions. Rewrite RBAC docs and add Mermaid diagrams #4469

Merged
merged 6 commits into from
Aug 13, 2024

Conversation

rolodato
Copy link
Member

@rolodato rolodato commented Aug 9, 2024

Deprecates group-level permissions. This is only a UI change and no action is required from customers. Added target=_blank to all links in the deprecation notice to avoid accidentally discarding any unsaved changes.

Can probably make more improvements to the docs here, but I'd be happy to merge it as-is.

The part about provisioning users and permissions is not strictly related to RBAC so it could go in its own document later on. This is probably the best place for it to be at the moment.

permissions.mov

@rolodato rolodato requested a review from a team as a code owner August 9, 2024 01:54
@rolodato rolodato requested review from gagantrivedi and removed request for a team August 9, 2024 01:54
Copy link

vercel bot commented Aug 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 13, 2024 1:22pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Aug 13, 2024 1:22pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Aug 13, 2024 1:22pm

@github-actions github-actions bot added the docs Documentation updates label Aug 9, 2024
@rolodato rolodato removed the request for review from gagantrivedi August 9, 2024 01:54
@rolodato rolodato changed the title Rewrite RBAC docs, add Mermaid diagrams docs: Rewrite RBAC docs, add Mermaid diagrams Aug 9, 2024
@rolodato rolodato requested a review from a team as a code owner August 12, 2024 20:59
@rolodato rolodato requested review from novakzaballa and removed request for a team August 12, 2024 20:59
@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Aug 12, 2024
Copy link
Contributor

github-actions bot commented Aug 12, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4469 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4469 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4469 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4469 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-4469 Finished ✅ Results

@github-actions github-actions bot added docs Documentation updates and removed docs Documentation updates labels Aug 12, 2024
@rolodato rolodato changed the title docs: Rewrite RBAC docs, add Mermaid diagrams docs: Deprecate group-level permissions. Rewrite RBAC docs and add Mermaid diagrams Aug 12, 2024
Copy link
Contributor

github-actions bot commented Aug 12, 2024

Uffizzi Preview deployment-55189 was deleted.

@rolodato rolodato requested review from dabeeeenster, kyle-ssg and matthewelwell and removed request for novakzaballa August 12, 2024 21:05
@rolodato rolodato force-pushed the docs/rbac-cr-clarify branch from 7f55028 to d17b081 Compare August 12, 2024 21:08
@github-actions github-actions bot added docs Documentation updates and removed docs Documentation updates labels Aug 12, 2024
@rolodato
Copy link
Member Author

Reminder before merging: add the actual Flagsmith version when this is released here https://github.com/Flagsmith/flagsmith/pull/4469/files#diff-a272079eeec1855f9514e0c2254805b5cc9dcc82b3e09f6e5d4a26cda188c4b1R123

Copy link
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work @rolodato. Love the initiative here, and the docs are very nice and clear!

@github-actions github-actions bot added docs Documentation updates and removed docs Documentation updates labels Aug 13, 2024
@rolodato rolodato added this pull request to the merge queue Aug 13, 2024
Merged via the queue into main with commit 19d5af9 Aug 13, 2024
21 checks passed
@rolodato rolodato deleted the docs/rbac-cr-clarify branch August 13, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation updates front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants