Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make influx cache task recurring #4495

Merged
merged 3 commits into from
Aug 15, 2024

Conversation

zachaysan
Copy link
Contributor

Changes

Stacking the task decorators doesn't work. I looked into the task processor implementation and I think it's because the wrapped function can't be called. So instead I just redefined the function with an extended name.

How did you test this code?

I did not test the code since the change is simple.

@zachaysan zachaysan requested a review from a team as a code owner August 14, 2024 14:56
@zachaysan zachaysan requested review from matthewelwell and removed request for a team August 14, 2024 14:56
Copy link

vercel bot commented Aug 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Aug 15, 2024 9:43am
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Aug 15, 2024 9:43am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Aug 15, 2024 9:43am

@zachaysan zachaysan requested review from khvn26 and removed request for matthewelwell August 14, 2024 14:56
@github-actions github-actions bot added api Issue related to the REST API fix labels Aug 14, 2024
Copy link
Contributor

github-actions bot commented Aug 14, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4495 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4495 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4495 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4495 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4495 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4495 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Aug 14, 2024

Uffizzi Preview deployment-55253 was deleted.

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.92%. Comparing base (a395a47) to head (52024bb).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4495   +/-   ##
=======================================
  Coverage   96.92%   96.92%           
=======================================
  Files        1177     1178    +1     
  Lines       39467    39490   +23     
=======================================
+ Hits        38253    38276   +23     
  Misses       1214     1214           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added fix and removed fix labels Aug 15, 2024
@github-actions github-actions bot added fix and removed fix labels Aug 15, 2024
@matthewelwell matthewelwell added this pull request to the merge queue Aug 15, 2024
Merged via the queue into main with commit cb8472d Aug 15, 2024
35 checks passed
@matthewelwell matthewelwell deleted the fix/make_influx_cache_task_recurring branch August 15, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants