Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update metadata/custom-fields screenshots. Fix broken links #4534

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

rolodato
Copy link
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Remove unused docs screenshots
  • Update screenshot that still referenced "Metadata" instead of "Custom fields"
  • Fix broken internal link to custom fields when no custom fields are configured
  • Fixed grammar in message when no custom fields are configured
  • Tweaked wording in custom fields UI

How did you test this code?

Manually, browse docs and custom fields pages locally

Copy link

vercel bot commented Aug 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2024 8:34pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2024 8:34pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2024 8:34pm

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard docs Documentation updates and removed docs Documentation updates labels Aug 22, 2024
@rolodato rolodato marked this pull request as ready for review August 22, 2024 20:35
@rolodato rolodato requested review from a team as code owners August 22, 2024 20:35
@rolodato rolodato requested review from kyle-ssg, matthewelwell and a team and removed request for a team and kyle-ssg August 22, 2024 20:35
@github-actions github-actions bot removed the docs Documentation updates label Aug 22, 2024
Copy link
Contributor

github-actions bot commented Aug 22, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4534 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4534 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4534 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4534 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4534 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-4534 Finished ✅ Results

@github-actions github-actions bot added the docs Documentation updates label Aug 22, 2024
Copy link
Contributor

github-actions bot commented Aug 22, 2024

Uffizzi Preview deployment-55491 was deleted.

@matthewelwell matthewelwell added this pull request to the merge queue Aug 23, 2024
Merged via the queue into main with commit 25f0ca2 Aug 23, 2024
51 checks passed
@matthewelwell matthewelwell deleted the docs/metadata-images branch August 23, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation updates front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants