Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add docs on pricing and API requests. Improve real-time docs #4566

Merged
merged 8 commits into from
Sep 4, 2024

Conversation

rolodato
Copy link
Member

@rolodato rolodato commented Aug 31, 2024

Copy link

vercel bot commented Aug 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2024 3:16pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Sep 4, 2024 3:16pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Sep 4, 2024 3:16pm

@rolodato rolodato marked this pull request as ready for review August 31, 2024 02:14
@rolodato rolodato requested a review from a team as a code owner August 31, 2024 02:14
@rolodato rolodato requested review from gagantrivedi and removed request for a team August 31, 2024 02:14
@rolodato rolodato changed the title docs: Add docs on pricing and API requests docs: Add docs on pricing and API requests. Improve real-time docs Aug 31, 2024
Copy link
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor comments.


## What counts as an API request?

Any operation that calls Flagsmith's API to retrieve information about the current state of flags counts as 1 billable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... this isn't completely true. We should also include something about identifying an identity and/or updating an identity's traits.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Identifying an identity still returns the current state of flags - it's the current state of flags as seen by a specific user.

Updating an identity's traits also returns the current state of flags for the identity that is being updated.

I tried to make this as generic as possible while not overwhelming with technical details, considering the audience for this document includes people who have not used Flagsmith at all.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also tried to make this explicit in the example below:

The device calls Flagsmith to update this user's traits and receives their latest flags in return (1 API request).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can solve any ambiguity here with a minor change to the wording:

Suggested change
Any operation that calls Flagsmith's API to retrieve information about the current state of flags counts as 1 billable
Any operation that calls Flagsmith's API to retrieve information about the current state of flags and/or persist an identity or their traits counts as 1 billable

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think having this level of technical detail in the first sentence does more harm than good. We don't need to introduce the concepts of identity or trait at this point - I've specifically avoided using the word "identity" as a Flagsmith concept in this doc to make it accessible for a wider audience, especially less-technical decision makers who don't care about these details.

In a separate PR, I could add a dedicated section with details on what actual endpoints are billed, things like /flags, /identities, /environment-document etc to detail the actual specifics.

Copy link
Member Author

@rolodato rolodato Sep 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another way to word this that is technically more accurate and doesn't add complexity could be:

Suggested change
Any operation that calls Flagsmith's API to retrieve information about the current state of flags counts as 1 billable
Any operation that calls Flagsmith's API and retrieves information about the current state of flags counts as 1 billable

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, good with me, apart from one minor typo: persist -> persists

docs/docs/pricing/index.mdx Outdated Show resolved Hide resolved
@matthewelwell matthewelwell added this pull request to the merge queue Sep 4, 2024
Merged via the queue into main with commit 7140dc3 Sep 4, 2024
11 checks passed
@matthewelwell matthewelwell deleted the docs/api-usage branch September 4, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants