Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add tag based permissions #4643

Closed
wants to merge 17 commits into from
Closed

feat: Add tag based permissions #4643

wants to merge 17 commits into from

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Sep 18, 2024 •
edited
Loading

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Supersedes #4250

Users can now create tag-based roles
image

A tag based role will let you specify relevant permissions

image

image

How did you test this code?

The frontend will check for any tag-based permissions if it cannot find any standard permissions. In this example my user can only update feature states for the marketing tag.

perms.mov

Needs #4799 to be implemented in order for it to work fully.

@kyle-ssg kyle-ssg requested review from a team as code owners September 18, 2024 18:47
@kyle-ssg kyle-ssg requested review from zachaysan and removed request for a team September 18, 2024 18:47
@vercel Vercel
Copy link

vercel bot commented Sep 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 1:03pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 1:03pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 1:03pm

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard docs Documentation updates labels Sep 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 18, 2024 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-4643 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-4643 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4643 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-4643 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4643 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-4643 Finished ✅ Results ✅

@kyle-ssg kyle-ssg requested review from rolodato and gagantrivedi and removed request for zachaysan September 18, 2024 18:48
@kyle-ssg kyle-ssg changed the title Add tag based permissions feat: Add tag based permissions Sep 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 18, 2024 •
edited
Loading

Uffizzi Preview deployment-58019 was deleted.

@rolodato
Copy link
Member

I don't understand how this is supposed to be used based on the docs description.

From what I understand, this functionality allows defining feature-level permissions so that only specific users can modify certain sensitive features. Happy to collaborate on these docs but I'd like to sync and understand how this functionality actually works first.

@kyle-ssg
Copy link
Member Author

I don't understand how this is supposed to be used based on the docs description.

From what I understand, this functionality allows defining feature-level permissions so that only specific users can modify certain sensitive features. Happy to collaborate on these docs but I'd like to sync and understand how this functionality actually works first.

It's quite hard to describe but it does work as updated in the docs.

If permissions are tagged, the following permissions will only be granted on features with matching tags:

  • Create feature, Update Feature, Segment Overrides, and Change Requests

If a user has admin permissions from another role or group it'll grant the user the missing permissions.

@kyle-ssg
Copy link
Member Author

kyle-ssg commented Sep 24, 2024 •
edited
Loading

@gagantrivedi cc just to confirm, were the missing permissions added? This used to be just update feature and segment override

@gagantrivedi
Copy link
Member

@gagantrivedi cc just to confirm, were the missing permissions added? This used to be just update feature and segment override

No, they are not added yet

@kyle-ssg
Merge branch 'refs/heads/main' into feat/tag-based-permissions
c8d4532 
# Conflicts:
#	frontend/common/types/requests.ts
#	frontend/web/components/tags/AddEditTags.tsx
@kyle-ssg
Merge
58e6478
@github-actions github-actions bot added feature New feature or request and removed docs Documentation updates labels Oct 8, 2024
This was linked to issues Oct 24, 2024
Restrict Permissions Based on Tags in Roles #4424
Closed
WIP: More granular feature level permissions #1535
Closed
@flagsmith flagsmith bot added the flagsmith flag The Issue/PR has a linked feaature flag in Flagsmith label Oct 30, 2024
@flagsmith Flagsmith
Copy link

flagsmith bot commented Oct 30, 2024

Flagsmith feature linked: tag_based_permissions
Default Values:

Environment Enabled Value Last Updated (UTC)
Production ❌ Disabled 2024-09-18 15:13:59
Staging ✅ Enabled 2024-09-18 15:18:34
Demo ❌ Disabled 2024-09-18 15:13:59
Self hosted defaults ❌ Disabled 2024-09-18 15:13:59

@flagsmith Flagsmith
Copy link

flagsmith bot commented Oct 30, 2024

Flagsmith Feature tag_based_permissions has been updated:

Segment flagsmith_team values:

Environment Enabled Value Last Updated (UTC)
Demo ✅ Enabled 2024-10-30 19:17:41

@github-actions github-actions bot added docs Documentation updates and removed feature New feature or request docs Documentation updates labels Nov 12, 2024
@github-actions github-actions bot added feature New feature or request docs Documentation updates and removed feature New feature or request docs Documentation updates labels Nov 12, 2024
@github-actions github-actions bot added docs Documentation updates feature New feature or request and removed feature New feature or request docs Documentation updates labels Nov 12, 2024
@kyle-ssg kyle-ssg removed a link to an issue Nov 12, 2024
Add "tag_based" field to role #4799
Closed
@github-actions github-actions bot added docs Documentation updates feature New feature or request and removed feature New feature or request docs Documentation updates labels Nov 13, 2024
@kyle-ssg kyle-ssg closed this Nov 19, 2024
@flagsmith Flagsmith
Copy link

flagsmith bot commented Dec 4, 2024

Flagsmith Feature tag_based_permissions has been updated:

Environment Enabled Value Last Updated (UTC)
Demo ✅ Enabled 2024-12-04 14:06:51

@flagsmith Flagsmith
Copy link

flagsmith bot commented Dec 4, 2024

Flagsmith Feature tag_based_permissions has been updated:

Environment Enabled Value Last Updated (UTC)
Production ✅ Enabled 2024-12-04 14:07:01

@flagsmith Flagsmith
Copy link

flagsmith bot commented Dec 5, 2024

Flagsmith Feature tag_based_permissions has been updated:

Segment qbiq values:

Environment Enabled Value Last Updated (UTC)
Production ✅ Enabled 2024-12-05 16:04:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolodato rolodato Awaiting requested review from rolodato

@gagantrivedi gagantrivedi Awaiting requested review from gagantrivedi

Assignees
No one assigned
Labels
feature New feature or request flagsmith flag The Issue/PR has a linked feaature flag in Flagsmith front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Restrict Permissions Based on Tags in Roles WIP: More granular feature level permissions
3 participants
@kyle-ssg @rolodato @gagantrivedi