Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: replace trivy scan action with one in Flagsmith/actions repo #4766

Merged
merged 4 commits into from
Nov 1, 2024

Conversation

matthewelwell
Copy link
Contributor

Changes

Replace trivy-scan-action with the one added to Flagsmith/actions repo as per this PR.

How did you test this code?

Workflows on this PR should test it (once the new version has been released)

Copy link

vercel bot commented Oct 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2024 6:41pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2024 6:41pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2024 6:41pm

@github-actions github-actions bot added the ci-cd Build, test and deployment related label Oct 23, 2024
Copy link
Contributor

github-actions bot commented Oct 23, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-4766 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-4766 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4766 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4766 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4766 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4766 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Oct 23, 2024

Uffizzi Preview deployment-57559 was deleted.

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.32%. Comparing base (6d2ab58) to head (b7792c0).
Report is 44 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4766      +/-   ##
==========================================
+ Coverage   97.21%   97.32%   +0.10%     
==========================================
  Files        1172     1179       +7     
  Lines       40535    41188     +653     
==========================================
+ Hits        39408    40088     +680     
+ Misses       1127     1100      -27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added ci-cd Build, test and deployment related and removed ci-cd Build, test and deployment related labels Oct 28, 2024
@github-actions github-actions bot added ci-cd Build, test and deployment related and removed ci-cd Build, test and deployment related labels Oct 28, 2024
@matthewelwell matthewelwell requested review from a team and khvn26 and removed request for a team October 29, 2024 17:36
Copy link
Member

@khvn26 khvn26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also change the cron .github/workflows/platform-docker-trivy-scan.yml workflow (or move it to the actions repo).

@github-actions github-actions bot added ci-cd Build, test and deployment related and removed ci-cd Build, test and deployment related labels Oct 30, 2024
@matthewelwell
Copy link
Contributor Author

We should also change the cron .github/workflows/platform-docker-trivy-scan.yml workflow (or move it to the actions repo).

Good catch. For now, I've just updated the workflow in this repository. In response to the point about moving it to the actions repository, I added a comment here to discuss further.

@matthewelwell matthewelwell requested a review from khvn26 November 1, 2024 08:54
@matthewelwell matthewelwell added this pull request to the merge queue Nov 1, 2024
Merged via the queue into main with commit ca8b9ed Nov 1, 2024
35 checks passed
@matthewelwell matthewelwell deleted the ci/move-trivy-action branch November 1, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-cd Build, test and deployment related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants